ALSA: timer: Remove kernel warning at compat ioctl error paths
authorTakashi Iwai <tiwai@suse.de>
Tue, 21 Nov 2017 15:36:11 +0000 (16:36 +0100)
committerBen Hutchings <ben@decadent.org.uk>
Tue, 13 Feb 2018 18:32:19 +0000 (18:32 +0000)
commitfe37537fcbfdd8caee979ad3114c5bbbb024605c
tree5ca1514d6a53c9fa2f3ea0ad2949b240ffd43f7e
parented20bb1ee26c1d737cb1db9353aae41b42b84550
ALSA: timer: Remove kernel warning at compat ioctl error paths

commit 3d4e8303f2c747c8540a0a0126d0151514f6468b upstream.

Some timer compat ioctls have NULL checks of timer instance with
snd_BUG_ON() that bring up WARN_ON() when the debug option is set.
Actually the condition can be met in the normal situation and it's
confusing and bad to spew kernel warnings with stack trace there.
Let's remove snd_BUG_ON() invocation and replace with the simple
checks.  Also, correct the error code to EBADFD to follow the native
ioctl error handling.

Reported-by: syzbot <syzkaller@googlegroups.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
sound/core/timer_compat.c