can: xilinx_can: fix comparison of unsigned variable
authorSudip Mukherjee <sudipm.mukherjee@gmail.com>
Tue, 18 Nov 2014 13:47:07 +0000 (19:17 +0530)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Tue, 18 Nov 2014 16:47:49 +0000 (17:47 +0100)
commitfb3ec7ba5a665c280f7299a36460449038fc1083
tree5abdbadb2ba03aeb6373c978d50874d4b853d1f2
parent4e2061b1e1f6b8e698b36a6518b6f8c15edc4547
can: xilinx_can: fix comparison of unsigned variable

The variable err was of the type u32. It was being compared with < 0, and being
an unsigned variable the comparison would have been always false.

Moreover, err was getting the return value from set_reset_mode() and
xcan_set_bittiming(), and both are returning int.

Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Reviewed-by: Michal Simek <michal.simek@xilinx.com>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
drivers/net/can/xilinx_can.c