PCI: Fix infinite loop with ROM image of size 0
authorMichel Dänzer <michel.daenzer@amd.com>
Mon, 19 Jan 2015 08:53:20 +0000 (17:53 +0900)
committerBen Hutchings <ben@decadent.org.uk>
Sat, 9 May 2015 22:16:13 +0000 (23:16 +0100)
commitf50587eec5cd5e7d78744f54364a14bb6b55adcc
tree7df66e9245a9b62f909a5ae15c813970ab604b48
parent16a0a3f34da7ba0054fe923156de1da87b933644
PCI: Fix infinite loop with ROM image of size 0

commit 16b036af31e1456cb69243a5a0c9ef801ecd1f17 upstream.

If the image size would ever read as 0, pci_get_rom_size() could keep
processing the same image over and over again.  Exit the loop if we ever
read a length of zero.

This fixes a soft lockup on boot when the radeon driver calls
pci_get_rom_size() on an AMD Radeon R7 250X PCIe discrete graphics card.

[bhelgaas: changelog, reference]
Link: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1386973
Reported-by: Federico <federicotg@gmail.com>
Signed-off-by: Michel Dänzer <michel.daenzer@amd.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/pci/rom.c