mmc: card: Fixup request missing in mmc_blk_issue_rw_rq
authorDing Wang <justin.wang@spreadtrum.com>
Mon, 18 May 2015 12:14:15 +0000 (20:14 +0800)
committerBen Hutchings <ben@decadent.org.uk>
Wed, 12 Aug 2015 14:33:16 +0000 (16:33 +0200)
commitf0f69fa1f5681291070806ffeefa1ed357696af8
tree41f2205be667d5a51fbc9a38ed6e383eab59662a
parentfc48056df5fc0a4ae5c5969599e03a4e237e3d10
mmc: card: Fixup request missing in mmc_blk_issue_rw_rq

commit 29535f7b797df35cc9b6b3bca635591cdd3dd2a8 upstream.

The current handler of MMC_BLK_CMD_ERR in mmc_blk_issue_rw_rq function
may cause new coming request permanent missing when the ongoing
request (previoulsy started) complete end.

The problem scenario is as follows:
(1) Request A is ongoing;
(2) Request B arrived, and finally mmc_blk_issue_rw_rq() is called;
(3) Request A encounters the MMC_BLK_CMD_ERR error;
(4) In the error handling of MMC_BLK_CMD_ERR, suppose mmc_blk_cmd_err()
    end request A completed and return zero. Continue the error handling,
    suppose mmc_blk_reset() reset device success;
(5) Continue the execution, while loop completed because variable ret
    is zero now;
(6) Finally, mmc_blk_issue_rw_rq() return without processing request B.

The process related to the missing request may wait that IO request
complete forever, possibly crashing the application or hanging the system.

Fix this issue by starting new request when reset success.

Signed-off-by: Ding Wang <justin.wang@spreadtrum.com>
Fixes: 67716327eec7 ("mmc: block: add eMMC hardware reset support")
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/mmc/card/block.c