skb: avoid unnecessary reallocations in __skb_cow
authorFelix Fietkau <nbd@openwrt.org>
Tue, 29 May 2012 03:35:08 +0000 (03:35 +0000)
committerBen Hutchings <ben@decadent.org.uk>
Sun, 10 Jun 2012 13:42:06 +0000 (14:42 +0100)
commiteaa74c53680f04bc6f9e79d930c532fb58d818d3
tree328913e9cec7d020394bd58b2c8e866b055c0ae0
parentba9ee5eb730f20bab874ba91d3dfec7816459dad
skb: avoid unnecessary reallocations in __skb_cow

[ Upstream commit 617c8c11236716dcbda877e764b7bf37c6fd8063 ]

At the beginning of __skb_cow, headroom gets set to a minimum of
NET_SKB_PAD. This causes unnecessary reallocations if the buffer was not
cloned and the headroom is just below NET_SKB_PAD, but still more than the
amount requested by the caller.
This was showing up frequently in my tests on VLAN tx, where
vlan_insert_tag calls skb_cow_head(skb, VLAN_HLEN).

Locally generated packets should have enough headroom, and for forward
paths, we already have NET_SKB_PAD bytes of headroom, so we don't need to
add any extra space here.

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
include/linux/skbuff.h