hrtimer: Prevent hrtimer_enqueue_reprogram race
authorLeonid Shatz <leonid.shatz@ravellosystems.com>
Mon, 4 Feb 2013 12:33:37 +0000 (14:33 +0200)
committerBen Hutchings <ben@decadent.org.uk>
Wed, 6 Mar 2013 03:23:49 +0000 (03:23 +0000)
commitd03659265edc9c622ecbdb94999a27f868a60a4b
tree6edb74365543eaad128865cc67185de8385bb6f5
parent6c4df7b1225c95b49bb13cef410277e342bb9b7b
hrtimer: Prevent hrtimer_enqueue_reprogram race

commit b22affe0aef429d657bc6505aacb1c569340ddd2 upstream.

hrtimer_enqueue_reprogram contains a race which could result in
timer.base switch during unlock/lock sequence.

hrtimer_enqueue_reprogram is releasing the lock protecting the timer
base for calling raise_softirq_irqsoff() due to a lock ordering issue
versus rq->lock.

If during that time another CPU calls __hrtimer_start_range_ns() on
the same hrtimer, the timer base might switch, before the current CPU
can lock base->lock again and therefor the unlock_timer_base() call
will unlock the wrong lock.

[ tglx: Added comment and massaged changelog ]

Signed-off-by: Leonid Shatz <leonid.shatz@ravellosystems.com>
Signed-off-by: Izik Eidus <izik.eidus@ravellosystems.com>
Cc: Andrea Arcangeli <aarcange@redhat.com>
Link: http://lkml.kernel.org/r/1359981217-389-1-git-send-email-izik.eidus@ravellosystems.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
kernel/hrtimer.c