xfrm: NULL dereference on allocation failure
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 14 Jun 2017 10:35:37 +0000 (13:35 +0300)
committerBen Hutchings <ben@decadent.org.uk>
Fri, 15 Sep 2017 17:30:54 +0000 (18:30 +0100)
commitc8ae75192b35dba6dba52bd457acb6cfbc90f9ce
tree6dc4050eddb0a130ce529cfeac81cbf94d899d66
parentf6f297642df7aeac0c5e323f9bc4f3fed0f8e09e
xfrm: NULL dereference on allocation failure

commit e747f64336fc15e1c823344942923195b800aa1e upstream.

The default error code in pfkey_msg2xfrm_state() is -ENOBUFS.  We
added a new call to security_xfrm_state_alloc() which sets "err" to zero
so there several places where we can return ERR_PTR(0) if kmalloc()
fails.  The caller is expecting error pointers so it leads to a NULL
dereference.

Fixes: df71837d5024 ("[LSM-IPSec]: Security association restriction.")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
net/key/af_key.c