usb: gadget: f_mass_storage: add missing memory barrier for thread_wakeup_needed
authorUCHINO Satoshi <satoshi.uchino@toshiba.co.jp>
Thu, 23 May 2013 02:10:11 +0000 (11:10 +0900)
committerBen Hutchings <ben@decadent.org.uk>
Sat, 27 Jul 2013 04:34:08 +0000 (05:34 +0100)
commitc818402a62e9b82e5c8552479a2c56bb8cdca3d9
tree7d7cf9b8e3a2151fcf4769336b4cdb98e1f25286
parentc5c54396415c451ae4540bb23a0d8cc5f6d71d7d
usb: gadget: f_mass_storage: add missing memory barrier for thread_wakeup_needed

commit d68c277b501889b3a50c179d1c3d704db7947b83 upstream.

Without this memory barrier, the file-storage thread may fail to
escape from the following while loop, because it may observe new
common->thread_wakeup_needed and old bh->state which are updated by
the callback functions.

/* Wait for the CBW to arrive */
while (bh->state != BUF_STATE_FULL) {
rc = sleep_thread(common);
if (rc)
return rc;
}

Signed-off-by: UCHINO Satoshi <satoshi.uchino@toshiba.co.jp>
Acked-by: Michal Nazarewicz <mina86@mina86.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/usb/gadget/f_mass_storage.c