ioremap: Delay sanity check until after a successful mapping
authorTim Gardner <tim.gardner@canonical.com>
Thu, 28 Apr 2011 17:00:30 +0000 (11:00 -0600)
committerIngo Molnar <mingo@elte.hu>
Fri, 29 Apr 2011 06:02:47 +0000 (08:02 +0200)
commitc7a7b814c9dca9ee01b38e63b4a46de87156d3b6
tree6cf6ab254dc918d4cedfa6c85b83cd9baa3d236a
parent64d21fc194e12bdf7347019bf10325a4b3d77e7b
ioremap: Delay sanity check until after a successful mapping

While tracking down the reason for an ioremap() failure I was
distracted  by the WARN_ONCE() in __ioremap_caller().

Performing a WARN_ONCE() sanity check before the mapping
is successful seems pointless if the caller sends bad values.

A case in point is when the BIOS provides erroneous screen_info
values causing vesafb_probe() to request an outrageuous size.
The WARN_ONCE is then wasted on bogosity. Move the warning to a
point where the mapping has been successfully allocated.

Addresses:

  http://bugs.launchpad.net/bugs/772042

Reviewed-by: Suresh Siddha <suresh.b.siddha@intel.com>
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
Link: http://lkml.kernel.org/r/4DB99D2E.9080106@canonical.com
Signed-off-by: Ingo Molnar <mingo@elte.hu>
arch/x86/mm/ioremap.c