xfs: prevent leaking uninitialized stack memory in FSGEOMETRY_V1
authorDan Rosenberg <drosenberg@vsecurity.com>
Mon, 14 Feb 2011 13:45:28 +0000 (13:45 +0000)
committerAlex Elder <aelder@sgi.com>
Tue, 22 Feb 2011 01:55:47 +0000 (19:55 -0600)
commitc4d0c3b097f7584772316ee4d64a09fe0e4ddfca
tree46ca0bf816086d7ac55ba0191e44119e14ef0d70
parent9681153b460006923bb1e9d39b05b80ec09d6b4e
xfs: prevent leaking uninitialized stack memory in FSGEOMETRY_V1

The FSGEOMETRY_V1 ioctl (and its compat equivalent) calls out to
xfs_fs_geometry() with a version number of 3.  This code path does not
fill in the logsunit member of the passed xfs_fsop_geom_t, leading to
the leaking of four bytes of uninitialized stack data to potentially
unprivileged callers.

v2 switches to memset() to avoid future issues if structure members
change, on suggestion of Dave Chinner.

Signed-off-by: Dan Rosenberg <drosenberg@vsecurity.com>
Reviewed-by: Eugene Teo <eugeneteo@kernel.org>
Signed-off-by: Alex Elder <aelder@sgi.com>
fs/xfs/xfs_fsops.c