percpu: fix pcpu_alloc_pages() failure path
authorTejun Heo <tj@kernel.org>
Fri, 15 Aug 2014 20:06:06 +0000 (16:06 -0400)
committerBen Hutchings <ben@decadent.org.uk>
Wed, 5 Nov 2014 20:27:38 +0000 (20:27 +0000)
commitc039250e175f15b4fa15c2aa6ae0b14162eff27d
tree477d2c23e31f7a30435049cc089a1be71e582d21
parent6856061748aced168123cc77a8c16ada57825719
percpu: fix pcpu_alloc_pages() failure path

commit f0d279654dea22b7a6ad34b9334aee80cda62cde upstream.

When pcpu_alloc_pages() fails midway, pcpu_free_pages() is invoked to
free what has already been allocated.  The invocation is across the
whole requested range and pcpu_free_pages() will try to free all
non-NULL pages; unfortunately, this is incorrect as
pcpu_get_pages_and_bitmap(), unlike what its comment suggests, doesn't
clear the pages array and thus the array may have entries from the
previous invocations making the partial failure path free incorrect
pages.

Fix it by open-coding the partial freeing of the already allocated
pages.

Signed-off-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
mm/percpu-vm.c