USB: fix race between root-hub resume and wakeup requests
authorAlan Stern <stern@rowland.harvard.edu>
Wed, 2 Feb 2011 18:59:33 +0000 (13:59 -0500)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 4 Feb 2011 00:46:48 +0000 (16:46 -0800)
commitbf3d7d40e42a85ca73a34e1385ff34f092a384eb
tree3e23ffdcf11823bc13e5e525ce36639e170cab94
parentd199c96d41d80a567493e12b8e96ea056a1350c1
USB: fix race between root-hub resume and wakeup requests

The USB core keeps track of pending resume requests for root hubs, in
order to resolve races between wakeup requests and suspends.  However
the code that does this is subject to another race (between wakeup
requests and resumes) because the WAKEUP_PENDING flag is cleared
before the resume occurs, leaving a window in which another wakeup
request might arrive.

This patch (as1447) fixes the problem by clearing the WAKEUP_PENDING
flag after the resume instead of before it.

This fixes Bugzilla #24952.

Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Tested-by: Paul Bender <pebender@san.rr.com>
Tested-by: warpme <warpme@o2.pl>
Cc: stable <stable@kernel.org> [.36+]
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/usb/core/hcd.c