ext3: Fix error handling on inode bitmap corruption
authorJan Kara <jack@suse.cz>
Thu, 8 Dec 2011 20:13:46 +0000 (21:13 +0100)
committerBen Hutchings <ben@decadent.org.uk>
Wed, 30 May 2012 23:43:52 +0000 (00:43 +0100)
commitb5451060a038e1d725d22ca8e852704903167514
tree2bfc2de659d7ec1bf7f8775ad5f502cd8748b1ef
parent13918f54a0987a9bcec568dd1c6300f1e8b1d05a
ext3: Fix error handling on inode bitmap corruption

commit 1415dd8705394399d59a3df1ab48d149e1e41e77 upstream.

When insert_inode_locked() fails in ext3_new_inode() it most likely
means inode bitmap got corrupted and we allocated again inode which
is already in use. Also doing unlock_new_inode() during error recovery
is wrong since inode does not have I_NEW set. Fix the problem by jumping
to fail: (instead of fail_drop:) which declares filesystem error and
does not call unlock_new_inode().

Reviewed-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
fs/ext3/ialloc.c