irq_remap: disable IRQ remapping if any IOAPIC lacks an IOMMU
authorSeth Forshee <seth.forshee@canonical.com>
Wed, 8 Aug 2012 13:27:03 +0000 (08:27 -0500)
committerBen Hutchings <ben@decadent.org.uk>
Wed, 10 Oct 2012 02:31:13 +0000 (03:31 +0100)
commitb4723adc0c336e153b6396f8c0e3f396cd9e9b5d
treeed497c3fd8fd3545b49426d0b58ca22502c1895c
parent3f00d57fffdf2708689bd75780cb0eeee26eedea
irq_remap: disable IRQ remapping if any IOAPIC lacks an IOMMU

commit 32ab31e01e2def6f48294d872d9bb42573aae00f upstream.

The ACPI tables in the Macbook Air 5,1 define a single IOAPIC with id 2,
but the only remapping unit described in the DMAR table matches id 0.
Interrupt remapping fails as a result, and the kernel panics with the
message "timer doesn't work through Interrupt-remapped IO-APIC."

To fix this, check each IOAPIC for a corresponding IOMMU. If an IOMMU is
not found, do not allow IRQ remapping to be enabled.

v2: Move check to parse_ioapics_under_ir(), raise log level to KERN_ERR,
    and add FW_BUG to the log message
v3: Skip check if IOMMU doesn't support interrupt remapping and remove
    existing check that the IOMMU count equals the IOAPIC count

Acked-by: Suresh Siddha <suresh.b.siddha@intel.com>
Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
Acked-by: Yinghai Lu <yinghai@kernel.org>
Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
[bwh: Backported to 3.2: adjust filename]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/iommu/intr_remapping.c