net/netfilter/ipvs: Eliminate memory leak
authorJulia Lawall <julia@diku.dk>
Tue, 24 Aug 2010 04:39:49 +0000 (04:39 +0000)
committerDavid S. Miller <davem@davemloft.net>
Wed, 25 Aug 2010 23:36:50 +0000 (16:36 -0700)
commitb2aff96327545aa5ceb25e3116be69c8b06de703
tree144aa0ed207b68e163d1d8f4f13971d1fb01edcd
parent8d34e7d6f38fce1c7e595404295494cd1eaba3eb
net/netfilter/ipvs: Eliminate memory leak

__ip_vs_service_get and __ip_vs_svc_fwm_get increment a reference count, so
that reference count should be decremented before leaving the function in an
error case.

A simplified version of the semantic match that finds this problem is:
(http://coccinelle.lip6.fr/)

// <smpl>
@r exists@
local idexpression x;
expression E;
identifier f1;
iterator I;
@@

x = __ip_vs_service_get(...);
<... when != x
     when != true (x == NULL || ...)
     when != if (...) { <+...x...+> }
     when != I (...) { <+...x...+> }
(
 x == NULL
|
 x == E
|
 x->f1
)
...>
* return ...;
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Simon Horman <horms@verge.net.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/netfilter/ipvs/ip_vs_ctl.c