ipv4: dst_entry leak in ip_send_unicast_reply()
authorVasily Averin <vvs@parallels.com>
Wed, 15 Oct 2014 12:24:02 +0000 (16:24 +0400)
committerBen Hutchings <ben@decadent.org.uk>
Thu, 1 Jan 2015 01:27:52 +0000 (01:27 +0000)
commitb136685fdeae304667ae14d59d51a965b0412c62
tree48f434d6b6943dfa33df91769e8ac19702afe3ba
parent724035313906d1569c81524132ef494ce1a112af
ipv4: dst_entry leak in ip_send_unicast_reply()

commit 4062090e3e5caaf55bed4523a69f26c3265cc1d2 upstream.

ip_setup_cork() called inside ip_append_data() steals dst entry from rt to cork
and in case errors in __ip_append_data() nobody frees stolen dst entry

Fixes: 2e77d89b2fa8 ("net: avoid a pair of dst_hold()/dst_release() in ip_append_data()")
Signed-off-by: Vasily Averin <vvs@parallels.com>
Acked-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
[bwh: Backported to 3.2: adjust context]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
net/ipv4/ip_output.c