ARM: 6975/1: pmu: reject duplicate PMU registrations
authorMark Rutland <mark.rutland@arm.com>
Wed, 22 Jun 2011 14:32:48 +0000 (15:32 +0100)
committerRussell King <rmk+kernel@arm.linux.org.uk>
Wed, 29 Jun 2011 09:27:08 +0000 (10:27 +0100)
commitae0c3751ab08d3fe039d48935e9ad2c46711b23b
tree7159b91bd55eb6e64032c84644a932a5cf35d9e8
parentf12482c9393da2c1f5cb3217f29aa79c653dd980
ARM: 6975/1: pmu: reject duplicate PMU registrations

Currently, the PMU reservation framework allows for multiple PMUs of
the same type to register themselves. This can lead to a bug with the
sequence:

register_pmu(pmu1);
reserve_pmu(pmu_type);
register_pmu(pmu2);
release_pmu(pmu1);

Here, pmu1 cannot be released, and pmu2 cannot be reserved.

This patch modifies register_pmu to reject registrations where a PMU is
already present, preventing this problem. PMUs which can have multiple
instances should not use the PMU reservation framework.

Signed-off-by: Mark Rutland <mark.rutland@arm.com>
Acked-by: Jamie Iles <jamie@jamieiles.com>
Acked-by: Will Deacon <will.deacon@arm.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
arch/arm/kernel/pmu.c