hw_breakpoint: Use cpu_possible_mask in {reserve,release}_bp_slot()
authorOleg Nesterov <oleg@redhat.com>
Thu, 20 Jun 2013 15:50:09 +0000 (17:50 +0200)
committerBen Hutchings <ben@decadent.org.uk>
Sat, 27 Jul 2013 04:34:13 +0000 (05:34 +0100)
commitac02af4cc6edcc26925b37f8e4c6c03a1b39a910
tree47cf74fd63cbd7d52ef078ce58acaf05fa07e542
parent965386e5345230cb27d840a272c3a5fe78fb9da7
hw_breakpoint: Use cpu_possible_mask in {reserve,release}_bp_slot()

commit c790b0ad23f427c7522ffed264706238c57c007e upstream.

fetch_bp_busy_slots() and toggle_bp_slot() use
for_each_online_cpu(), this is obviously wrong wrt cpu_up() or
cpu_down(), we can over/under account the per-cpu numbers.

For example:

# echo 0 >> /sys/devices/system/cpu/cpu1/online
# perf record -e mem:0x10 -p 1 &
# echo 1 >> /sys/devices/system/cpu/cpu1/online
# perf record -e mem:0x10,mem:0x10,mem:0x10,mem:0x10 -C1 -a &
# taskset -p 0x2 1

triggers the same WARN_ONCE("Can't find any breakpoint slot") in
arch_install_hw_breakpoint().

Reported-by: Vince Weaver <vincent.weaver@maine.edu>
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Frederic Weisbecker <fweisbec@gmail.com>
Link: http://lkml.kernel.org/r/20130620155009.GA6327@redhat.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
kernel/events/hw_breakpoint.c