8021q: fix a potential use-after-free
authorCong Wang <amwang@redhat.com>
Fri, 22 Mar 2013 19:14:07 +0000 (19:14 +0000)
committerBen Hutchings <ben@decadent.org.uk>
Wed, 10 Apr 2013 02:20:11 +0000 (03:20 +0100)
commita7fe44f2340bd4c77428ad97f903ff31e67d6208
treec6a10a5e2013a60ef6b5aa7c484bd2159ea999e9
parent4289cdeb48d9d5d2674a85e63b315d4771bf4d27
8021q: fix a potential use-after-free

[ Upstream commit 4a7df340ed1bac190c124c1601bfc10cde9fb4fb ]

vlan_vid_del() could possibly free ->vlan_info after a RCU grace
period, however, we may still refer to the freed memory area
by 'grp' pointer. Found by code inspection.

This patch moves vlan_vid_del() as behind as possible.

Cc: Patrick McHardy <kaber@trash.net>
Cc: "David S. Miller" <davem@davemloft.net>
Signed-off-by: Cong Wang <amwang@redhat.com>
Acked-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
net/8021q/vlan.c