net: force a reload of first item in hlist_nulls_for_each_entry_rcu
authorEric Dumazet <eric.dumazet@gmail.com>
Wed, 29 May 2013 09:06:27 +0000 (09:06 +0000)
committerBen Hutchings <ben@decadent.org.uk>
Sat, 29 Jun 2013 03:06:40 +0000 (04:06 +0100)
commit9fb13f7e3023941beb41536f399c065acdb4a1a6
tree9b37fb489cba552dd4a7858f4e73f75bce16b00c
parent8beeb76aa534e9312fdae1c91ab3a2effc847ee5
net: force a reload of first item in  hlist_nulls_for_each_entry_rcu

[ Upstream commit c87a124a5d5e8cf8e21c4363c3372bcaf53ea190 ]

Roman Gushchin discovered that udp4_lib_lookup2() was not reloading
first item in the rcu protected list, in case the loop was restarted.

This produced soft lockups as in https://lkml.org/lkml/2013/4/16/37

rcu_dereference(X)/ACCESS_ONCE(X) seem to not work as intended if X is
ptr->field :

In some cases, gcc caches the value or ptr->field in a register.

Use a barrier() to disallow such caching, as documented in
Documentation/atomic_ops.txt line 114

Thanks a lot to Roman for providing analysis and numerous patches.

Diagnosed-by: Roman Gushchin <klamm@yandex-team.ru>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: Boris Zhmurov <zhmurov@yandex-team.ru>
Signed-off-by: Roman Gushchin <klamm@yandex-team.ru>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
include/linux/rculist_nulls.h