zram: use zram->lock to protect zram_free_page() in swap free notify path
authorJiang Liu <liuj97@gmail.com>
Thu, 6 Jun 2013 16:07:23 +0000 (00:07 +0800)
committerBen Hutchings <ben@decadent.org.uk>
Sat, 27 Jul 2013 04:34:07 +0000 (05:34 +0100)
commit9e443904906ca2b5b3ae71f34ac4a4fa6905623e
tree026657122c99b02939c22d720e2632aedc821a7c
parentfd162a76f16083157e32fe5f488f39a319b93fad
zram: use zram->lock to protect zram_free_page() in swap free notify path

commit 57ab048532c0d975538cebd4456491b5c34248f4 upstream.

zram_slot_free_notify() is free-running without any protection from
concurrent operations. So there are race conditions between
zram_bvec_read()/zram_bvec_write() and zram_slot_free_notify(),
and possible consequences include:
1) Trigger BUG_ON(!handle) on zram_bvec_write() side.
2) Access to freed pages on zram_bvec_read() side.
3) Break some fields (bad_compress, good_compress, pages_stored)
   in zram->stats if the swap layer makes concurrently call to
   zram_slot_free_notify().

So enhance zram_slot_free_notify() to acquire writer lock on zram->lock
before calling zram_free_page().

Signed-off-by: Jiang Liu <jiang.liu@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/staging/zram/zram_drv.c
drivers/staging/zram/zram_drv.h