cgroup: fix mount failure in a corner case
authorLi Zefan <lizefan@huawei.com>
Mon, 30 Jun 2014 03:49:58 +0000 (11:49 +0800)
committerTejun Heo <tj@kernel.org>
Mon, 30 Jun 2014 14:16:25 +0000 (10:16 -0400)
commit970317aa48c6ef66cd023c039c2650c897bad927
tree6308e957b9690395717c0894dd339505d1071d9a
parent391acf970d21219a2a5446282d3b20eace0c0d7a
cgroup: fix mount failure in a corner case

  # cat test.sh
  #! /bin/bash

  mount -t cgroup -o cpu xxx /cgroup
  umount /cgroup

  mount -t cgroup -o cpu,cpuacct xxx /cgroup
  umount /cgroup
  # ./test.sh
  mount: xxx already mounted or /cgroup busy
  mount: according to mtab, xxx is already mounted on /cgroup

It's because the cgroupfs_root of the first mount was under destruction
asynchronously.

Fix this by delaying and then retrying mount for this case.

v3:
- put the refcnt immediately after getting it. (Tejun)

v2:
- use percpu_ref_tryget_live() rather that introducing
  percpu_ref_alive(). (Tejun)
- adjust comment.

tj: Updated the comment a bit.

Cc: <stable@vger.kernel.org> # 3.15
Signed-off-by: Li Zefan <lizefan@huawei.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
kernel/cgroup.c