CIFS: Don't free volume_info->UNC until we are entirely done with it.
authorJesper Juhl <jj@chaosbits.net>
Sat, 27 Aug 2011 16:58:34 +0000 (18:58 +0200)
committerJiri Kosina <jkosina@suse.cz>
Tue, 27 Sep 2011 16:08:04 +0000 (18:08 +0200)
commit95c754545353ca7db2e12485546eac626f8461f9
treee923f1bf64bd74fc09ba9960777f437952029431
parentbfb9035c98906aafcd3cf22694fba2550997bf53
CIFS: Don't free volume_info->UNC until we are entirely done with it.

In cleanup_volume_info_contents() we kfree(volume_info->UNC); and then
proceed to use that variable on the very next line.
This causes (at least) Coverity Prevent to complain about use-after-free
of that variable (and I guess other checkers may do that as well).
There's not any /real/ problem here since we are just using the value of
the pointer, not actually dereferencing it, but it's still trivial to
silence the tool, so why not?
To me at least it also just seems nicer to defer freeing the variable
until we are entirely done with it in all respects.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Reviewed-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
fs/cifs/connect.c