drivers/video/msm/mdp.c: adjust error handling code
authorJulia Lawall <julia@diku.dk>
Mon, 4 Jul 2011 14:11:45 +0000 (16:11 +0200)
committerPaul Mundt <lethal@linux-sh.org>
Wed, 13 Jul 2011 07:49:37 +0000 (16:49 +0900)
commit945903c7a477784e796168ef87b5022241cb52b5
tree25c77ed310b3fcacb81cfc7707749c45a60a145c
parent8d86e5f91440aa56a5df516bf58fe3883552ad56
drivers/video/msm/mdp.c: adjust error handling code

Use the error handling code at the end of the function, rather than
returning directly.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@r@
identifier x;
@@

kfree(x)

@@
identifier r.x;
expression E1!=0,E2,E3,E4;
statement S;
@@

(
if (<+...x...+>) S
|
if (...) { ... when != kfree(x)
               when != if (...) { ... kfree(x); ... }
               when != x = E3
* return E1;
}
... when != x = E2
if (...) { ... when != x = E4
 kfree(x); ... return ...; }
)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Paul Mundt <lethal@linux-sh.org>
drivers/video/msm/mdp.c