git.openpandora.org / pandora-kernel.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: f6d8c8b) | patch
powerpc/pmac: Add missing unlocks in error path
authorJulia Lawall <julia@diku.dk>
Mon, 29 Mar 2010 05:34:46 +0000 (05:34 +0000)
committerBenjamin Herrenschmidt <benh@kernel.crashing.org>
Wed, 7 Apr 2010 08:00:44 +0000 (18:00 +1000)
commit86e4754ac8fde9a9c913571016bc31257aa2e195
treec96a3df8769e488a6a03e40c330e9cacc872045atree | snapshot
parentf6d8c8bb1d360272d795927d39f3d2c5934e77d9commit | diff
powerpc/pmac: Add missing unlocks in error path

In some error handling cases the lock is not unlocked.

A simplified version of the semantic patch that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@r exists@
expression E1;
identifier f;
@@

f (...) { <+...
* spin_lock_irqsave (E1,...);
... when != E1
* return ...;
...+> }
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
drivers/macintosh/macio-adb.c diff | blob | history
drivers/macintosh/smu.c diff | blob | history
Pandora Kernel Repository