ipv6 mcast: use in6_dev_put in timer handlers instead of __in6_dev_put
authorSalam Noureddine <noureddine@aristanetworks.com>
Sun, 29 Sep 2013 20:41:34 +0000 (13:41 -0700)
committerBen Hutchings <ben@decadent.org.uk>
Sat, 26 Oct 2013 20:06:09 +0000 (21:06 +0100)
commit765844f8edd831563fc646c7f747abf89eef4d4d
tree518faf8fdf63c513a05195f351da7b41ca176715
parent003efcca2ad3e471e9103688a715bd33e29cb37b
ipv6 mcast: use in6_dev_put in timer handlers instead of __in6_dev_put

[ Upstream commit 9260d3e1013701aa814d10c8fc6a9f92bd17d643 ]

It is possible for the timer handlers to run after the call to
ipv6_mc_down so use in6_dev_put instead of __in6_dev_put in the
handler function in order to do proper cleanup when the refcnt
reaches 0. Otherwise, the refcnt can reach zero without the
inet6_dev being destroyed and we end up leaking a reference to
the net_device and see messages like the following,

unregister_netdevice: waiting for eth0 to become free. Usage count = 1

Tested on linux-3.4.43.

Signed-off-by: Salam Noureddine <noureddine@aristanetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
net/ipv6/mcast.c