mfd: max8925: Fix possible NULL pointer dereference on i2c_new_dummy error
authorKrzysztof Kozlowski <k.kozlowski@samsung.com>
Tue, 11 Feb 2014 10:03:33 +0000 (11:03 +0100)
committerBen Hutchings <ben@decadent.org.uk>
Wed, 30 Apr 2014 15:23:22 +0000 (16:23 +0100)
commit758e64a56d3220edc5097d97cba1104530661fd2
treed3c402cc24e101b0ba0345d7c905649bed0da53e
parentc330c022ae163cc84eff086720e28562570c2eaa
mfd: max8925: Fix possible NULL pointer dereference on i2c_new_dummy error

commit 96cf3dedc491d2f1f66cc26217f2b06b0c7b6797 upstream.

During probe the driver allocates dummy I2C devices for RTC and ADC
with i2c_new_dummy() but it does not check the return value of this
calls.

In case of error (i2c_new_device(): memory allocation failure or I2C
address cannot be used) this function returns NULL which is later used
by i2c_unregister_device().

If i2c_new_dummy() fails for RTC or ADC devices, fail also the probe
for main MFD driver.

Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/mfd/max8925-i2c.c