libiscsi: fix potential buffer overrun in __iscsi_conn_send_pdu
authorMike Christie <michaelc@cs.wisc.edu>
Wed, 3 Sep 2014 05:00:39 +0000 (00:00 -0500)
committerBen Hutchings <ben@decadent.org.uk>
Wed, 5 Nov 2014 20:27:44 +0000 (20:27 +0000)
commit74cb172240786f18938ab882c552e49a05a2cbc8
tree522f0394b0ecec3a38e957e3e898aa0f279fb734
parent5bd3c0477993f54bac2c4618655e4102ffe1fab4
libiscsi: fix potential buffer overrun in __iscsi_conn_send_pdu

commit db9bfd64b14a3a8f1868d2164518fdeab1b26ad1 upstream.

This patches fixes a potential buffer overrun in __iscsi_conn_send_pdu.
This function is used by iscsi drivers and userspace to send iscsi PDUs/
commands. For login commands, we have a set buffer size. For all other
commands we do not support data buffers.

This was reported by Dan Carpenter here:
http://www.spinics.net/lists/linux-scsi/msg66838.html

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
Reviewed-by: Sagi Grimberg <sagig@mellanox.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/scsi/libiscsi.c