[PATCH] net core: Some interface flags not returned by SIOCGIFFLAGS
authorJohn Dykstra <john.dykstra1@gmail.com>
Fri, 12 Jun 2009 03:57:21 +0000 (20:57 -0700)
committerDavid S. Miller <davem@davemloft.net>
Fri, 12 Jun 2009 03:57:21 +0000 (20:57 -0700)
commit746e6ad23cd6fec2edce056e014a0eabeffa838c
treef44de53e3fca1db32fee3c81ac87229c1f895cb3
parent8981f01001c616f58f1623ecadfab8b1ed758da7
[PATCH] net core: Some interface flags not returned by SIOCGIFFLAGS

Commit b00055aacdb172c05067612278ba27265fcd05ce " [NET] core: add
RFC2863 operstate" defined new interface flag values.  Its
documentation specified that these flags could be accessed from user
space via SIOCGIFFLAGS.  However, this does not work because the new
flags do not fit in that ioctl's argument width.

Change the documentation to match the code's behavior.  Also change
the source to explicitly show the truncation.  This _should_ have no
effect on executable code, and did not with gcc 4.2.4 generating x86
code.

A new ioctl could be defined to return all interface flags to user
space.  However, since this has been broken for three years with no
one complaining, there doesn't seem much need.  They are still
accessible via netlink.

Reported-by: "Fredrik Arnerup" <fredrik.arnerup@edgeware.tv>
Signed-off-by: John Dykstra <john.dykstra1@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Documentation/networking/operstates.txt
net/core/dev.c