slub: fix a possible memleak in __slab_alloc()
authorEric Dumazet <eric.dumazet@gmail.com>
Tue, 13 Dec 2011 03:57:06 +0000 (04:57 +0100)
committerPekka Enberg <penberg@kernel.org>
Tue, 13 Dec 2011 20:11:21 +0000 (22:11 +0200)
commit73736e0387ba0e6d2b703407b4d26168d31516a7
tree448f2d85f82462096d55c93f15cea9876665faaa
parent25f4379b8c79066c4be0e5995f37f5265733b801
slub: fix a possible memleak in __slab_alloc()

Zhihua Che reported a possible memleak in slub allocator on
CONFIG_PREEMPT=y builds.

It is possible current thread migrates right before disabling irqs in
__slab_alloc(). We must check again c->freelist, and perform a normal
allocation instead of scratching c->freelist.

Many thanks to Zhihua Che for spotting this bug, introduced in 2.6.39

V2: Its also possible an IRQ freed one (or several) object(s) and
populated c->freelist, so its not a CONFIG_PREEMPT only problem.

Cc: <stable@vger.kernel.org> [2.6.39+]
Reported-by: Zhihua Che <zhihua.che@gmail.com>
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Acked-by: Christoph Lameter <cl@linux.com>
Signed-off-by: Pekka Enberg <penberg@kernel.org>
mm/slub.c