drm/nouveau/fbcon: using nv_two_heads is not a good idea
authorBen Skeggs <bskeggs@redhat.com>
Tue, 26 Jun 2012 02:12:30 +0000 (12:12 +1000)
committerBen Hutchings <ben@decadent.org.uk>
Wed, 4 Jul 2012 04:44:16 +0000 (05:44 +0100)
commit6fd8c58dd9675aa0f984c9a1c604a4a8d9ca4c3b
tree300dab4e65737369d7c223f4670c19f0c053eea8
parent707799fd0d6ccc157f40d9a6685e97a65bea7b71
drm/nouveau/fbcon: using nv_two_heads is not a good idea

commit 9bd0c15fcfb42f6245447c53347d65ad9e72080b upstream.

nv_two_heads() was never meant to be used outside of pre-nv50 code.  The
code checks for >= NV_10 for 2 CRTCs, then downgrades a few specific
chipsets to 1 CRTC based on (pci_device & 0x0ff0).

The breakage example seen is on GTX 560Ti, with a pciid of 0x1200, which
gets detected as an NV20 (0x020x) with 1 CRTC by nv_two_heads(), causing
memory corruption because there's actually 2 CRTCs..

This switches fbcon to use the CRTC count directly from the mode_config
structure, which will also fix the same issue on Kepler boards which have
4 CRTCs.

Signed-off-by: Ben Skeggs <bskeggs@redhat.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/gpu/drm/nouveau/nouveau_fbcon.c