kprobes: initialize before using a hlist
authorAnanth N Mavinakayanahalli <ananth@in.ibm.com>
Fri, 20 Jan 2012 22:34:04 +0000 (14:34 -0800)
committerGreg Kroah-Hartman <gregkh@suse.de>
Thu, 26 Jan 2012 00:13:57 +0000 (16:13 -0800)
commit6ee7663e972835367a550bd6b9fecc1a9dc14ce1
treedbce6c001ccf5319ccbd5a0b2b45a4f75756fa65
parentbdac3a105a1c8fdf89ea15404ad5c7bcec73d37a
kprobes: initialize before using a hlist

commit d496aab567e7e52b3e974c9192a5de6e77dce32c upstream.

Commit ef53d9c5e ("kprobes: improve kretprobe scalability with hashed
locking") introduced a bug where we can potentially leak
kretprobe_instances since we initialize a hlist head after having used
it.

Initialize the hlist head before using it.

Reported by: Jim Keniston <jkenisto@us.ibm.com>
Acked-by: Jim Keniston <jkenisto@us.ibm.com>
Signed-off-by: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Srinivasa D S <srinivasa@in.ibm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
kernel/kprobes.c