nfsd: stricter decoding of write-like NFSv2/v3 ops
authorJ. Bruce Fields <bfields@redhat.com>
Fri, 21 Apr 2017 19:26:30 +0000 (15:26 -0400)
committerBen Hutchings <ben@decadent.org.uk>
Mon, 5 Jun 2017 20:13:56 +0000 (21:13 +0100)
commit6b9ba0c00cb068a50a409bbdc7cfbe473f1c01a3
treef0689d0249c6d5fb642b706731d2578e7e4d5919
parent4625f286522abbb36c49a17cdb9c0bc008fd3ce2
nfsd: stricter decoding of write-like NFSv2/v3 ops

commit 13bf9fbff0e5e099e2b6f003a0ab8ae145436309 upstream.

The NFSv2/v3 code does not systematically check whether we decode past
the end of the buffer.  This generally appears to be harmless, but there
are a few places where we do arithmetic on the pointers involved and
don't account for the possibility that a length could be negative.  Add
checks to catch these.

Reported-by: Tuomas Haanpää <thaan@synopsys.com>
Reported-by: Ari Kauppi <ari@synopsys.com>
Reviewed-by: NeilBrown <neilb@suse.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
fs/nfsd/nfs3xdr.c
fs/nfsd/nfsxdr.c