nfs: fix null checking in nfs_get_option_str()
authorXi Wang <xi.wang@gmail.com>
Fri, 4 Jan 2013 08:22:57 +0000 (03:22 -0500)
committerBen Hutchings <ben@decadent.org.uk>
Wed, 16 Jan 2013 01:13:19 +0000 (01:13 +0000)
commit66ebe467a6dbbd0b3917ef6ad1bd4930f9b8185d
tree0d629daaeac9721a933ae9709a96adbb5f807c2d
parentc69aab88b3a960f9d41a8d2c467eb61f613cbea7
nfs: fix null checking in nfs_get_option_str()

commit e25fbe380c4e3c09afa98bcdcd9d3921443adab8 upstream.

The following null pointer check is broken.

*option = match_strdup(args);
return !option;

The pointer `option' must be non-null, and thus `!option' is always false.
Use `!*option' instead.

The bug was introduced in commit c5cb09b6f8 ("Cleanup: Factor out some
cut-and-paste code.").

Signed-off-by: Xi Wang <xi.wang@gmail.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
fs/nfs/super.c