Revert "tcp: Apply device TSO segment limit earlier"
authorBen Hutchings <ben@decadent.org.uk>
Tue, 10 Feb 2015 00:05:18 +0000 (00:05 +0000)
committerBen Hutchings <ben@decadent.org.uk>
Fri, 20 Feb 2015 00:49:33 +0000 (00:49 +0000)
commit649917478f4c580f6c0a46c99ebff7381581530b
tree58777d362c8297297de6ce2a6c44c67e961a84c9
parent9fefe0d3228bb6a874bf3bf7628dd198347abf64
Revert "tcp: Apply device TSO segment limit earlier"

This reverts commit 9f871e883277cc22c6217db806376dce52401a31, which
was commit 1485348d2424e1131ea42efc033cbd9366462b01 upstream.

It can cause connections to stall when a PMTU event occurs.  This was
fixed by commit 843925f33fcc ("tcp: Do not apply TSO segment limit to
non-TSO packets") upstream, but that depends on other changes to TSO.

The original issue this fixed was a performance regression for the sfc
driver in extreme cases of TSO (skb with > 100 segments).  This is not
really very important and it seems best to revert it rather than try
to fix it up.

Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: netdev@vger.kernel.org
Cc: linux-net-drivers@solarflare.com
include/net/sock.h
net/core/sock.c
net/ipv4/tcp.c
net/ipv4/tcp_cong.c
net/ipv4/tcp_output.c