Redefine ATOMIC_INIT and ATOMIC64_INIT to drop the casts
authorMel Gorman <mgorman@suse.de>
Sun, 19 Aug 2012 02:41:03 +0000 (14:41 +1200)
committerBen Hutchings <ben@decadent.org.uk>
Wed, 12 Sep 2012 02:37:14 +0000 (03:37 +0100)
commit55add10c00b8ddd4cc091fa7e5dc974a0985fd90
tree280ccc69dcbc8456bac86429ed6de38d193d121a
parentc93f5803e234956a070c7c443fb5a4620d012cc8
Redefine ATOMIC_INIT and ATOMIC64_INIT to drop the casts

commit 67a806d9499353fabd5b5ff07337f3aa88a1c3ba upstream.

The following build error occurred during an alpha build:

  net/core/sock.c:274:36: error: initializer element is not constant

Dave Anglin says:
> Here is the line in sock.i:
>
> struct static_key memalloc_socks = ((struct static_key) { .enabled =
> ((atomic_t) { (0) }) });

The above line contains two compound literals.  It also uses a designated
initializer to initialize the field enabled.  A compound literal is not a
constant expression.

The location of the above statement isn't fully clear, but if a compound
literal occurs outside the body of a function, the initializer list must
consist of constant expressions.

Signed-off-by: Mel Gorman <mgorman@suse.de>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Michael Cree <mcree@orcon.net.nz>
Acked-by: Matt Turner <mattst88@gmail.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
arch/alpha/include/asm/atomic.h