KVM: protect assigned dev workqueue, int handler and irq acker
authorMarcelo Tosatti <mtosatti@redhat.com>
Thu, 7 May 2009 20:55:13 +0000 (17:55 -0300)
committerAvi Kivity <avi@redhat.com>
Wed, 10 Jun 2009 08:48:53 +0000 (11:48 +0300)
commit547de29e5b1662deb05b5f90917902dc0e9ac182
treec8c8d913729f4577251d3bceb9fe52b676f7a5a8
parent32f8840064d88cc3f6e85203aec7b6b57bebcb97
KVM: protect assigned dev workqueue, int handler and irq acker

kvm_assigned_dev_ack_irq is vulnerable to a race condition with the
interrupt handler function. It does:

        if (dev->host_irq_disabled) {
                enable_irq(dev->host_irq);
                dev->host_irq_disabled = false;
        }

If an interrupt triggers before the host->dev_irq_disabled assignment,
it will disable the interrupt and set dev->host_irq_disabled to true.

On return to kvm_assigned_dev_ack_irq, dev->host_irq_disabled is set to
false, and the next kvm_assigned_dev_ack_irq call will fail to reenable
it.

Other than that, having the interrupt handler and work handlers run in
parallel sounds like asking for trouble (could not spot any obvious
problem, but better not have to, its fragile).

CC: sheng.yang@intel.com
Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
Signed-off-by: Avi Kivity <avi@redhat.com>
include/linux/kvm_host.h
virt/kvm/kvm_main.c