md: change bitmap_unplug and others to void functions
authorNeilBrown <neilb@suse.de>
Tue, 17 Jul 2007 11:06:13 +0000 (04:06 -0700)
committerLinus Torvalds <torvalds@woody.linux-foundation.org>
Tue, 17 Jul 2007 17:23:15 +0000 (10:23 -0700)
commit4ad1366376bfef32ec0ffa12d1faa483d6f330bd
tree87a9c864ec5ebd446f6c99f3298bc7638efa8f1e
parentf0d76d70bc77b9b11256a3a23e98e80878be1578
md: change bitmap_unplug and others to void functions

bitmap_unplug only ever returns 0, so it may as well be void.  Two callers try
to print a message if it returns non-zero, but that message is already printed
by bitmap_file_kick.

write_page returns an error which is not consistently checked.  It always
causes BITMAP_WRITE_ERROR to be set on an error, and that can more
conveniently be checked.

When the return of write_page is checked, an error causes bitmap_file_kick to
be called - so move that call into write_page - and protect against recursive
calls into bitmap_file_kick.

bitmap_update_sb returns an error that is never checked.

So make these 'void' and be consistent about checking the bit.

Signed-off-by: Neil Brown <neilb@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/md/bitmap.c
drivers/md/md.c
drivers/md/raid1.c
drivers/md/raid10.c
include/linux/raid/bitmap.h