spi/amba-pl022: Fix error case return statement.
authorJulia Lawall <julia@diku.dk>
Wed, 29 Sep 2010 08:31:30 +0000 (17:31 +0900)
committerGrant Likely <grant.likely@secretlab.ca>
Wed, 29 Sep 2010 08:31:30 +0000 (17:31 +0900)
commit4a4fd47155ac49b62de5177a780c245e967752f3
treeab6fb77775382247056d1dff975db326541d2432
parente447d3588e1c5944f607083cb509663f8015d420
spi/amba-pl022: Fix error case return statement.

The return -EINVAL appears to only make sense if the if branch that it is
aligned with is taken, and the indentation indicates that this is the
authors intent, so move it into that branch.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@r disable braces4@
position p1,p2;
statement S1,S2;
@@

(
if (...) { ... }
|
if (...) S1@p1 S2@p2
)

@script:python@
p1 << r.p1;
p2 << r.p2;
@@

if (p1[0].column == p2[0].column):
  cocci.print_main("branch",p1)
  cocci.print_secs("after",p2)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
drivers/spi/amba-pl022.c