xfs: fix missing error check in xfs_rtfree_range
authorDave Chinner <david@fromorbit.com>
Thu, 14 Jan 2010 08:44:46 +0000 (08:44 +0000)
committerAlex Elder <aelder@sgi.com>
Fri, 15 Jan 2010 19:46:19 +0000 (13:46 -0600)
commit3daeb42c13567e1505f233f6a699cc0e23c8ab5a
treea5897b35cb4830d73089aace8abd5b2c8bae1d7f
parent4b6a46882cca8349e8942e2650c33b11bc571c92
xfs: fix missing error check in xfs_rtfree_range

When xfs_rtfind_forw() returns an error, the block is returned
uninitialised.  xfs_rtfree_range() is not checking the error return,
so could be using an uninitialised block number for modifying bitmap
summary info.

The problem was found by gcc when compiling the *userspace* libxfs
code - it is an copy of the kernel code with the exact same bug.
gcc gives an uninitialised variable warning on the userspace code
but not on the kernel code. You gotta love the consistency (Mmmm,
slightly chewy today!).

Signed-off-by: Dave Chinner <david@fromorbit.com>
Signed-off-by: Alex Elder <aelder@sgi.com>
fs/xfs/xfs_rtalloc.c