git.openpandora.org / pandora-kernel.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 2308f4a) | patch
ALSA: 6fire: Fix double-free bug in usb6fire_fw_ezusb_upload()
authorJesper Juhl <jj@chaosbits.net>
Mon, 13 Jun 2011 21:52:02 +0000 (23:52 +0200)
committerTakashi Iwai <tiwai@suse.de>
Tue, 14 Jun 2011 05:27:26 +0000 (07:27 +0200)
commit37f7ec38ea5c31180461f82e895e13fdd549b595
treeedabbd3298390da475ea280030c1cf870aac8818tree | snapshot
parent2308f4add3de9f6c9c9f02e49461e94d84bb200acommit | diff
ALSA: 6fire: Fix double-free bug in usb6fire_fw_ezusb_upload()

We have a double-free bug in
sound/usb/6fire/firmware.c::usb6fire_fw_ezusb_upload().
We already call release_firmware(fw) on line 258, so when we then do it
again after usb6fire_fw_ezusb_write() returns <0, we have a double-free.
Easily fixed by just removing the last call to release_firmware().

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/usb/6fire/firmware.c diff | blob | history
Pandora Kernel Repository