NLM: nlm_lookup_file() may return NLMv4-specific error codes
authorTrond Myklebust <Trond.Myklebust@netapp.com>
Sat, 13 Oct 2012 04:30:28 +0000 (00:30 -0400)
committerBen Hutchings <ben@decadent.org.uk>
Tue, 30 Oct 2012 23:26:49 +0000 (23:26 +0000)
commit34fb2c5983d16fac57b1ff78b5dbfe98b12bbde0
tree7273cbed1cd9d90534a72a580b3b72da262d749f
parent4bd0ee768c5242d7ae09dbb66c9e531a22da1f68
NLM: nlm_lookup_file() may return NLMv4-specific error codes

commit cd0b16c1c3cda12dbed1f8de8f1a9b0591990724 upstream.

If the filehandle is stale, or open access is denied for some reason,
nlm_fopen() may return one of the NLMv4-specific error codes nlm4_stale_fh
or nlm4_failed. These get passed right through nlm_lookup_file(),
and so when nlmsvc_retrieve_args() calls the latter, it needs to filter
the result through the cast_status() machinery.

Failure to do so, will trigger the BUG_ON() in encode_nlm_stat...

Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Reported-by: Larry McVoy <lm@bitmover.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
fs/lockd/clntxdr.c
fs/lockd/svcproc.c