x86, efi: Only close open files in error path
authorMatt Fleming <matt.fleming@intel.com>
Thu, 15 Mar 2012 19:13:25 +0000 (19:13 +0000)
committerH. Peter Anvin <hpa@zytor.com>
Fri, 1 Jun 2012 16:11:10 +0000 (09:11 -0700)
commit30dc0d0fe5d08396dbdaa2d70972149131340960
tree7c875693d5e31a18ebe635612503be876472c96e
parentfb21affa49204acd409328415b49bfe90136653c
x86, efi: Only close open files in error path

The loop at the 'close_handles' label in handle_ramdisks() should be
using 'i', which represents the number of initrd files that were
successfully opened, not 'nr_initrds' which is the number of initrd=
arguments passed on the command line.

Currently, if we execute the loop to close all file handles and we
failed to open any initrds we'll try to call the close function on a
garbage pointer, causing the machine to hang.

Cc: Matthew Garrett <mjg@redhat.com>
Signed-off-by: Matt Fleming <matt.fleming@intel.com>
Link: http://lkml.kernel.org/r/1331907517-3985-2-git-send-email-matt@console-pimps.org
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
arch/x86/boot/compressed/eboot.c