git.openpandora.org / pandora-kernel.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 4437ecd) | patch
ALSA: usb/mixer: remove bogus cast
authorDan Carpenter <error27@gmail.com>
Thu, 16 Sep 2010 18:13:47 +0000 (20:13 +0200)
committerTakashi Iwai <tiwai@suse.de>
Thu, 16 Sep 2010 20:50:51 +0000 (22:50 +0200)
commit26e34e9e15aa48e9375ea4e97bc4234ad995b7c8
tree803a156b7a34a76bce5576c6c68fc0061e4372f9tree | snapshot
parent4437ecdc7190302ed02fb1467c116aff29c325b2commit | diff
ALSA: usb/mixer: remove bogus cast

"uinfo->value.enumerated.item" is an unsigned int.  If it's negative
when we do the comparison:
if ((int)uinfo->value.enumerated.item >= cval->max)
then we would read past the end of the array on the next line.

I also changed the strcpy() to strlcpy() out of paranoia.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/usb/mixer.c diff | blob | history
Pandora Kernel Repository