l2tp: fix oops in l2tp_eth_create() error path
authorTom Parkin <tparkin@katalix.com>
Mon, 29 Oct 2012 23:41:48 +0000 (23:41 +0000)
committerBen Hutchings <ben@decadent.org.uk>
Fri, 16 Nov 2012 16:47:17 +0000 (16:47 +0000)
commit20f2d6825ac85669edc96717f584a7194c4f3af6
treecd6e2005e571655f3e783bb911fd11c902428aa0
parentdf769f065d7bebf0ddc5f61605dbb1d8ea5ee2d8
l2tp: fix oops in l2tp_eth_create() error path

[ Upstream commit 789336360e0a2aeb9750c16ab704a02cbe035e9e ]

When creating an L2TPv3 Ethernet session, if register_netdev() should fail for
any reason (for example, automatic naming for "l2tpeth%d" interfaces hits the
32k-interface limit), the netdev is freed in the error path.  However, the
l2tp_eth_sess structure's dev pointer is left uncleared, and this results in
l2tp_eth_delete() then attempting to unregister the same netdev later in the
session teardown.  This results in an oops.

To avoid this, clear the session dev pointer in the error path.

Signed-off-by: Tom Parkin <tparkin@katalix.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
net/l2tp/l2tp_eth.c