usb: hub: take hub->hdev reference when processing from eventlist
authorJoe Lawrence <joe.lawrence@stratus.com>
Wed, 10 Sep 2014 19:07:50 +0000 (15:07 -0400)
committerBen Hutchings <ben@decadent.org.uk>
Wed, 5 Nov 2014 20:27:42 +0000 (20:27 +0000)
commit1c20e37c1d0975eca131a6b1d86f3a50d3e4caac
tree295be59f3c26242db6a54e8faf224984b9aa62b5
parent9a91e2d1a2a7c521b1ca22dd4216bc1f4fb81cbc
usb: hub: take hub->hdev reference when processing from eventlist

commit c605f3cdff53a743f6d875b76956b239deca1272 upstream.

During surprise device hotplug removal tests, it was observed that
hub_events may try to call usb_lock_device on a device that has already
been freed. Protect the usb_device by taking out a reference (under the
hub_event_lock) when hub_events pulls it off the list, returning the
reference after hub_events is finished using it.

Signed-off-by: Joe Lawrence <joe.lawrence@stratus.com>
Suggested-by: David Bulkow <david.bulkow@stratus.com> for using kref
Suggested-by: Alan Stern <stern@rowland.harvard.edu> for placement
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/usb/core/hub.c