dm: handle requests beyond end of device instead of using BUG_ON
authorMike Snitzer <snitzer@redhat.com>
Wed, 26 Sep 2012 22:45:42 +0000 (23:45 +0100)
committerBen Hutchings <ben@decadent.org.uk>
Wed, 10 Oct 2012 02:31:05 +0000 (03:31 +0100)
commit1bd6669684e5b889713164a76d42250afefdd1aa
treed86ae11d69b15f0186c3a888de6e39f1e358074f
parentb39bfb4cc09a0663d13b537e69e8241e6cc8ce71
dm: handle requests beyond end of device instead of using BUG_ON

commit ba1cbad93dd47223b1f3b8edd50dd9ef2abcb2ed upstream.

The access beyond the end of device BUG_ON that was introduced to
dm_request_fn via commit 29e4013de7ad950280e4b2208 ("dm: implement
REQ_FLUSH/FUA support for request-based dm") was an overly
drastic (but simple) response to this situation.

I have received a report that this BUG_ON was hit and now think
it would be better to use dm_kill_unmapped_request() to fail the clone
and original request with -EIO.

map_request() will assign the valid target returned by
dm_table_find_target to tio->ti.  But when the target
isn't valid tio->ti is never assigned (because map_request isn't
called); so add a check for tio->ti != NULL to dm_done().

Reported-by: Mike Christie <michaelc@cs.wisc.edu>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Signed-off-by: Jun'ichi Nomura <j-nomura@ce.jp.nec.com>
Signed-off-by: Alasdair G Kergon <agk@redhat.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/md/dm.c