pci: Don't crash when reading mpss from root complex
authorBenjamin Herrenschmidt <benh@kernel.crashing.org>
Tue, 13 Sep 2011 18:16:33 +0000 (15:16 -0300)
committerLinus Torvalds <torvalds@linux-foundation.org>
Tue, 13 Sep 2011 23:08:31 +0000 (16:08 -0700)
commit1a4b1a41b8a3d5256019854e851beed063b34344
treefa62183e093cf032c74cac8149fb69a49b07b7e0
parent2f4d3218e95d48de2951dcf2bea619ea49ef93de
pci: Don't crash when reading mpss from root complex

In pcie_find_smpss(), we have the following statement:

  if (dev->is_hotplug_bridge && (!list_is_singular(&dev->bus->devices) ||
    dev->bus->self->pcie_type != PCI_EXP_TYPE_ROOT_PORT))

The problem is that at least on my machine, this gets called for the
root complex (virtual P2P bridge), and dev->bus->self is NULL since
the parent bus for this is not itself anchor to a PCI device.

This adds the necessary NULL check.

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Acked-by: Jon Mason <mason@myri.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/pci/probe.c