tcp_cubic: fix the range of delayed_ack
authorLiu Yu <allanyuliu@tencent.com>
Wed, 30 Apr 2014 09:34:09 +0000 (17:34 +0800)
committerBen Hutchings <ben@decadent.org.uk>
Mon, 9 Jun 2014 12:28:58 +0000 (13:28 +0100)
commit1773b01be8aefeba20d2590e976f82292cf24b10
tree82d0d9db0380bbc4033679aaab4c05a9890cd715
parent4f75832e76aed7d308acde9bb0aba34218ef2b81
tcp_cubic: fix the range of delayed_ack

[ Upstream commit 0cda345d1b2201dd15591b163e3c92bad5191745 ]

commit b9f47a3aaeab (tcp_cubic: limit delayed_ack ratio to prevent
divide error) try to prevent divide error, but there is still a little
chance that delayed_ack can reach zero. In case the param cnt get
negative value, then ratio+cnt would overflow and may happen to be zero.
As a result, min(ratio, ACK_RATIO_LIMIT) will calculate to be zero.

In some old kernels, such as 2.6.32, there is a bug that would
pass negative param, which then ultimately leads to this divide error.

commit 5b35e1e6e9c (tcp: fix tcp_trim_head() to adjust segment count
with skb MSS) fixed the negative param issue. However,
it's safe that we fix the range of delayed_ack as well,
to make sure we do not hit a divide by zero.

CC: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: Liu Yu <allanyuliu@tencent.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Acked-by: Neal Cardwell <ncardwell@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
net/ipv4/tcp_cubic.c