VIDEO: Correct use of request_region/request_mem_region
authorJulia Lawall <julia@diku.dk>
Sun, 9 Aug 2009 09:42:32 +0000 (11:42 +0200)
committerRalf Baechle <ralf@linux-mips.org>
Wed, 2 Dec 2009 23:58:32 +0000 (23:58 +0000)
commit0fdd07f77fd9cc6a7d49076793daef06ea5d8f13
tree368db433db7c1927a3eddb8b746b4038172053c0
parentdbf763a2f1c117cfe45bbbd2c874a150f0e0900b
VIDEO: Correct use of request_region/request_mem_region

request_region should be used with release_region, not request_mem_region.

Geert Uytterhoeven pointed out that in the case of drivers/video/gbefb.c,
the problem is actually the other way around; request_mem_region should be
used instead of request_region.

The semantic patch that finds/fixes this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@r1@
expression start;
@@

request_region(start,...)

@b1@
expression r1.start;
@@

request_mem_region(start,...)

@depends on !b1@
expression r1.start;
expression E;
@@

- release_mem_region
+ release_region
  (start,E)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
drivers/video/gbefb.c